[Xen-devel] RE: [PATCH] xen,tools: pincpu use vcpu and cpumap_t

["Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>]

>      int err, errno_saved;
>      dom0_op_t op;
> +    u32 vcpu = 0; /* FIXME, hard coded initial pin to vcpu 0 */
> +    cpumap_t cpumap = 1<<cpu;

Ryan,
I haven't looked at the whole patch yet, but this comment worried me, as
it reminded me of a slightly wider change that I think we need to
address at the same time. 

We should remove the initial CPU allocation algorithm from xen
altogether, and leave it to xend (implementing the same ht-aware
algorithm), setting an appropriate pin map for each vcpu. The whole
pining stuff should be removed from xc_domain_create too as it doesn't
belong there.

I'd be inclined to go for something bigger than a long for the size of
the bitmap in the xc interface, even if we only look at the first 32/64
bits within Xen.

Best,
Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel