[Xen-devel] Re: [Xen-changelog] big cleanup. better support for refresh.

[Rik van Riel <riel@xxxxxxxxxx>]

On Fri, 1 Apr 2005, BitKeeper Bot wrote:

> diff -Nru a/linux-2.6.11-xen-sparse/drivers/xen/blkfront/vbd.c 
> b/linux-2.6.11-xen-sparse/drivers/xen/blkfront/vbd.c
> --- a/linux-2.6.11-xen-sparse/drivers/xen/blkfront/vbd.c      2005-04-01 
> 09:03:00 -05:00
> +++ b/linux-2.6.11-xen-sparse/drivers/xen/blkfront/vbd.c      2005-04-01 
> 09:03:00 -05:00

> +static struct lvdisk * xlvbd_device_alloc(void)
> +{
> +    struct lvdisk *ret;
> +
> +    ret = kmalloc(sizeof(struct lvdisk), GFP_KERNEL);
> +    if ( ret ) {
> +        memset(ret, '\0', 0);

*BLINK*

Surely that should be "memset(ret, '\0', sizeof(struct lvdisk));" ?

> +        INIT_LIST_HEAD(&ret->list);
> +    }
> +    return ret;
> +}


Signed-off-by: Rik van Riel <riel@xxxxxxxxxx>

--- linux-2.6.11/drivers/xen/blkfront/vbd.c.memset      2005-04-25 
12:36:26.000000000 -0400
+++ linux-2.6.11/drivers/xen/blkfront/vbd.c     2005-04-25 12:36:39.000000000 
-0400
@@ -108,7 +108,7 @@ static struct lvdisk * xlvbd_device_allo
 
     ret = kmalloc(sizeof(struct lvdisk), GFP_KERNEL);
     if ( ret ) {
-        memset(ret, '\0', 0);
+        memset(ret, '\0', sizeof(struct lvdisk));
         INIT_LIST_HEAD(&ret->list);
     }
     return ret;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel