Re: [Xen-devel] [patch] pagetable cleanups, next version

[Chris Wright <chrisw@xxxxxxxx>]

* Gerd Knorr (kraxel@xxxxxxxxxxx) wrote:
> There is the new l?e_has_changed() function which can be used to compare
> two page table entries.  It takes ptr's to two page table entries and a
> bitmask with the page flags it should care about.  The function will
> also deal with PAGE_MASK, so this is gone from the functions calling
> into l?e_has_changed().
> 
> In that particular function I also ditched the MATCH_ENTRY() macro which
> did something simliar to l?e_has_changed() in a less generic way.  That
> makes the code look even more different, although it _should_ be the
> same logic and it IMHO is also more readable.  I admit that I havn't
> tested shadow mode though ...
> 
> > Looks like create plus has changed is the new way?
> 
> Huh?  I lost you here ...

Sorry, that was my bad shorhand for l1e_create followed by l1e_has_changed.
Thanks for confirmation/explanation.

-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel