RE: [Xen-devel] [patch] pagetable cleanups

["Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>]

> 4) There was probably a bunch of debate about this somewhere 
> before, but I missed it.
>    The macros which set/clear page table types don't obey C's 
> pass-by-value calling
>    semantics.  That means that they can't be replaced with 
> simple functions, if
>    desired -- there would always have to be a macro layer.  
> There's also no macros
>    for creating L1E or L2E as expressions -- only statements 
> which assign them.
>    Perhaps this was intentional?  It means that you end up 
> declaring extra
>    variables to hold essentially temporary values in a few places...
> Comments?

I know it's a total pain in the arse, but I'm actually quite convinced
by Michael's argument. Having the 'create' macros return a struct is
actually much nicer for building expressions. 

I want to get this stuff checked in soon, though.

Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel