Re: [Xen-devel] [PATCH] stream fixes for migration

[David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>]

Mark Williamson wrote:
> > doing anything to a c stream will work in a multithreaded environment; ie,
> > the internal buffers/vars will not be stompped on.
> >
> > It's in the spec(don't ask me where, I read it in the info docs).
> I think the issue is with Xfrd's IOStream type (libxutil/iostream.h), rather 
> than with standard C streams.
> (and I don't know if they're safe for multiple users, although I would expect 
> that they're single thread-oriented)
Well, the patch seemed to be assuming that they don't need to be safe for
multiple threads. For example, the patch tries to make multiple closes safe,
but this won't work if the closes are concurrent. I was just checking that
no-one was expecting this to work.

--
David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel