[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] RE: follow-up to guest debug support patches
Kip, Here's a compendium of collectd comments on the patch. Shouldn't take long to either address them or explain them. Best, Ian It should at some point be extended to allow multiple exec_domains like gdb supports multiple threads in a single process. patch1: It seems to be missing a way to undo the foreign mappings on exit? The memcpy copying the user_ctxt is now after if gets used (addtl. VMX checks) Looks like he wasn't too careful when forward porting -- scary :-( Maybe the VMX check should just look at the context passed in. Not sure why he's skipping setting DONEFPUINIT, kernel mode and clearing IOPL bits though. Doesn't the change in traps.c break in-guest debugger support? It seems to always pause the domain if it is in kernel, an in-guest debugger which has set a breakpoint in the kernel will never get the int3. I think this needs some kind of flag to enable/disable this behaviour. patch2: adresses point2 above Now same concern applies to do_debug as for int3 I think the order in arch_final_setup_guest should be: - check cs/ss in passed in cpu_ctxt (before doing anything) - update DONEFPUINIT and TF_kernel_mode flags - copy user_ctxt - copy fpu ctxt - clear iopl - exit if updating (EDF_DONEINIT) ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |