Re: [Xen-devel] [PATCH] list.h minor clean

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

> Hi all,
> 
>       When I added (the typesafe) list_for_each_entry() to Linux's list.h I
> considered just calling it list_for_each(), and replacing all the
> callers, but the size of the task defeated me.  Xen, however, is
> smaller.
> 
> You may think this patch sucks, but I had to try.  Boot tested.

I like it. I've always disliked the Linux use of list_entry() to get
the containing structure. I'll read through it a bit more carefully
and then check it in. Thanks!

I may keep the rename though -- some other arch developers want to
pull in or symlink to unmodified Linux source files, and they won;t
appreciate the name clash. :-)

> Rusty.
> PS.  I haven't seen a discussion on codingstyle: some of these are
> definitely not Linux-style...

I hate that the Linux style uses 8-space hard tabs. I could live with
it apart from that.

 -- Keir


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel