[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-cim] Xen_HostedComputerSystem and miscellanous patch
Gareth,
So, will it be all right to move similar patches to the
other XenHostedXXXX files (like XenHostedDisk etc)?
What can we start working on next?
Any comments on the Gap document?
thanks
Raj From: Gareth S Bestor [mailto:bestor@xxxxxxxxxx] Sent: Thursday, May 18, 2006 1:36 AM To: Subrahmanian, Raj; xen-cim@xxxxxxxxxxxxxxxxxxx Subject: Re: [Xen-cim] Xen_HostedComputerSystem and miscellanous patch All these patches are appropriate, and great! Thanks!! - Changes Xen_HostedComputerSystem.c to - Decide the targetclass by using CMClassNameIsA rather than strcmp Yup - this is the correct approach. I must confess that Xen_HostedComputerSystem was one of the first associations I coded up (quickly) and I did the class comparison the quick-and-dirty strcmp way [well, OK, I did know *precisely* the target classname that our in-house mgmt app would be using, so I guess it wasnt THAT dirty...]. Some of the later association providers do the classname check correctly, as above. Jim - Can you/are you committing these patches? If you recall, I can only commit patches coming from IBM... - Gareth Dr. Gareth S. Bestor IBM Linux Technology Center M/S DES2-01 15300 SW Koll Parkway, Beaverton, OR 97006 503-578-3186, T/L 775-3186, Fax 503-578-3186
This patch contains the following changes - Changes Xen_ComputerSystem.mof to inherit from CIM_ComputerSystem rather than CIM_VirtualComputerSystem - Changes Xen_HostedComputerSystem.mof to make the antecedent CIM_ComputerSystem, rather than Linux_ComputerSystem - Changes Xen_HostedComputerSystem.c to - Decide the targetclass by using CMClassNameIsA rather than strcmp - Eliminate the Xen_ComputerSystem from the classes returned from the CIMOM. I did this by returning only those classes that do not match the source class rather than returning the class that exactly match the target class Raj _______________________________________________ Xen-cim mailing list Xen-cim@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-cim _______________________________________________ Xen-cim mailing list Xen-cim@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-cim
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |