[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] x86: apic: use APIC_EOI_ACK instead of open-coded 0



commit 5081b6649809e0eb54111bff56ea84035a490134
Author:     Denis Mukhin <dmukhin@xxxxxxxx>
AuthorDate: Thu Nov 5 09:49:07 2026 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Nov 5 09:49:07 2026 +0100

    x86: apic: use APIC_EOI_ACK instead of open-coded 0
    
    Use the symbolic value in ack_APIC_irq() instead of open-coded 0.
    
    Also, correct the EIO -> EOI typo in the constant name.
    
    Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/include/asm/apic.h    | 3 +--
 xen/arch/x86/include/asm/apicdef.h | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/include/asm/apic.h b/xen/arch/x86/include/asm/apic.h
index f30d57ad22..a4f6d2c26c 100644
--- a/xen/arch/x86/include/asm/apic.h
+++ b/xen/arch/x86/include/asm/apic.h
@@ -155,8 +155,7 @@ void apic_wait_icr_idle(void);
 
 static inline void ack_APIC_irq(void)
 {
-       /* Docs say use 0 for future compatibility */
-       apic_write(APIC_EOI, 0);
+       apic_write(APIC_EOI, APIC_EOI_ACK);
 }
 
 extern int get_maxlvt(void);
diff --git a/xen/arch/x86/include/asm/apicdef.h 
b/xen/arch/x86/include/asm/apicdef.h
index 112c1dc613..d3dc7b1d76 100644
--- a/xen/arch/x86/include/asm/apicdef.h
+++ b/xen/arch/x86/include/asm/apicdef.h
@@ -25,7 +25,7 @@
 #define                        APIC_ARBPRI_MASK        0xFF
 #define                APIC_PROCPRI    0xA0
 #define                APIC_EOI        0xB0
-#define                        APIC_EIO_ACK            0x0             /* 
Write this to the EOI register */
+#define                        APIC_EOI_ACK            0x0             /* Docs 
say use 0 for future compatibility */
 #define                APIC_RRR        0xC0
 #define                APIC_LDR        0xD0
 #define                        APIC_LDR_MASK           (0xFFu<<24)
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.