[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging-4.20] x86/amd: Fix inverted condition in zenbleed_use_chickenbit()



commit 589ac1f997528e33fecb68e815f8b894763fd8ea
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Tue Sep 29 16:46:06 2026 +0100
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Tue Oct 13 14:02:22 2026 +0100

    x86/amd: Fix inverted condition in zenbleed_use_chickenbit()
    
    The identified commit inverted the condition under which Xen chooses
    to set the Zenbleed chickenbit.
    
    Undo that, and leave a better comment explaining why.
    
    Found by AI review of the referenced commit.
    
    This is XSA-515 / CVE-2026-79608.
    
    Fixes: d0c75dc4c028 ("x86/amd: Fix race editing DE_CFG")
    Assisted-by: Sashiko + Opus 5.0
    Reported-by: George Dunlap <dunlapg@xxxxxxxxx>
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
    (cherry picked from commit 0c5ec39d9106e6a06bf153400e8e1e324e457583)
---
 xen/arch/x86/cpu/amd.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c
index 3914032269..d56e02323b 100644
--- a/xen/arch/x86/cpu/amd.c
+++ b/xen/arch/x86/cpu/amd.c
@@ -926,7 +926,12 @@ static bool zenbleed_use_chickenbit(void)
         return is_zen2_uarch();
     }
 
-    return (uint8_t)curr_rev >= fixed_rev;
+    /*
+     * Zenbleed can be mitigated by disabling Floating-Point
+     * Mov-Elimination, but this is expensive.  Only do so when we
+     * don't have a fix in microcode.
+     */
+    return (uint8_t)curr_rev < fixed_rev;
 }
 
 void amd_init_de_cfg(const struct cpuinfo_x86 *c)
--
generated by git-patchbot for /home/xen/git/xen.git#staging-4.20



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.