[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] xmalloc: drop pool list



commit 2dc805ceae42b23ee3fdff9fac0848bf6ffbbc38
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Jul 1 14:14:59 2026 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Jul 1 14:14:59 2026 +0200

    xmalloc: drop pool list
    
    From its introduction it has been used solely to add and remove pools.
    No list traversal or alike did ever occur. Drop all of this as being dead
    code.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/common/xmalloc_tlsf.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/xen/common/xmalloc_tlsf.c b/xen/common/xmalloc_tlsf.c
index 5e55fc463e..b43219b4af 100644
--- a/xen/common/xmalloc_tlsf.c
+++ b/xen/common/xmalloc_tlsf.c
@@ -66,9 +66,6 @@
 #define PREV_FREE       (0x2)
 #define PREV_USED       (0x0)
 
-static DEFINE_SPINLOCK(pool_list_lock);
-static LIST_HEAD(pool_list_head);
-
 struct free_ptr {
     struct bhdr *prev;
     struct bhdr *next;
@@ -113,8 +110,6 @@ struct xmem_pool {
     xmem_pool_get_memory *get_mem;
     xmem_pool_put_memory *put_mem;
 
-    struct list_head list;
-
     char name[MAX_POOL_NAME_LEN];
 };
 
@@ -340,10 +335,6 @@ struct xmem_pool *xmem_pool_create(
 
     spin_lock_init(&pool->lock);
 
-    spin_lock(&pool_list_lock);
-    list_add_tail(&pool->list, &pool_list_head);
-    spin_unlock(&pool_list_lock);
-
     return pool;
 }
 
@@ -373,10 +364,6 @@ void xmem_pool_destroy(struct xmem_pool *pool)
                "%lu bytes still in use.\n",
                pool->name, pool, xmem_pool_get_used_size(pool));
 
-    spin_lock(&pool_list_lock);
-    list_del_init(&pool->list);
-    spin_unlock(&pool_list_lock);
-
     pool_bytes = ROUNDUP_SIZE(sizeof(*pool));
     pool_order = get_order_from_bytes(pool_bytes);
     free_xenheap_pages(pool,pool_order);
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.