[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] x86/PV: drop a local variable from pv_emulate_gate_op()



commit 2220363115909988d3d0535a5cea349505f5b2c8
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Jun 3 08:17:23 2026 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Jun 3 08:17:23 2026 +0200

    x86/PV: drop a local variable from pv_emulate_gate_op()
    
    The inner "rc" shadows the function scope one, thus violating Misra C:2012
    rule 5.3 ("An identifier declared in an inner scope shall not hide an
    identifier declared in an outer scope"). Drop the inner variable, as
    there's no other (later) use of the value it holds.
    
    No difference in generated code.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
---
 xen/arch/x86/pv/emul-gate-op.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/x86/pv/emul-gate-op.c b/xen/arch/x86/pv/emul-gate-op.c
index d0f7f06e01..05262a983a 100644
--- a/xen/arch/x86/pv/emul-gate-op.c
+++ b/xen/arch/x86/pv/emul-gate-op.c
@@ -287,7 +287,6 @@ void pv_emulate_gate_op(struct cpu_user_regs *regs)
     {
         unsigned int ss, esp, *stkp;
         uint32_t value;
-        int rc;
 #define push(item) do \
         { \
             value = (item); \
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.