[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] tools/xenstored: remove unneeded check in create_node()



commit 7273bac8ae131e1ee161631afc466ba31c7fc85e
Author:     Juergen Gross <jgross@xxxxxxxx>
AuthorDate: Tue Apr 21 09:15:10 2026 +0200
Commit:     Anthony PERARD <anthony.perard@xxxxxxxxxx>
CommitDate: Thu Apr 23 17:39:55 2026 +0200

    tools/xenstored: remove unneeded check in create_node()
    
    create_node() is called only for issued xenstore commands. This means
    that the "conn" parameter is never NULL.
    
    Remove checking whether "conn" is not NULL.
    
    Coverity ID: 1690859
    
    Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
    Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
 tools/xenstored/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
index f92fca6e9e..6d82111e29 100644
--- a/tools/xenstored/core.c
+++ b/tools/xenstored/core.c
@@ -1524,7 +1524,7 @@ static struct node *create_node(struct connection *conn, 
const void *ctx,
        if (!node)
                return NULL;
 
-       if (conn && conn->transaction)
+       if (conn->transaction)
                ta_node_created(conn->transaction);
 
        node->data = data;
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.