|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen staging] xen/efi: Reduce ifdefary in efi_exit_boot()
commit c16b0e5273ea6012e5b497368967075bef541496
Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Thu Apr 9 11:30:30 2026 +0100
Commit: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Thu Apr 9 21:04:58 2026 +0100
xen/efi: Reduce ifdefary in efi_exit_boot()
Use IS_ENABLED() rather than #ifdef to give the compiler visibility into the
block, which in turn removes the #ifdef from the variable block.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
---
xen/common/efi/boot.c | 48 ++++++++++++++++++++++++------------------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index 0ddc7bfd12..b44762878b 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1335,9 +1335,7 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle,
EFI_SYSTEM_TABLE *Syste
EFI_STATUS status;
UINTN info_size = 0, map_key;
bool retry;
-#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
unsigned int i;
-#endif
efi_bs->GetMemoryMap(&info_size, NULL, &map_key,
&efi_mdesc_size, &mdesc_ver);
@@ -1371,31 +1369,33 @@ static void __init efi_exit_boot(EFI_HANDLE
ImageHandle, EFI_SYSTEM_TABLE *Syste
if ( EFI_ERROR(status) )
PrintErrMesg(L"Cannot exit boot services", status);
-#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP
- for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size )
+ if ( IS_ENABLED(CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP) )
{
- EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i;
+ for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size )
+ {
+ EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i;
- /*
- * Runtime services regions are always mapped here.
- * Attributes may be adjusted in efi_init_memory().
- */
- if ( (desc->Attribute & EFI_MEMORY_RUNTIME) ||
- desc->Type == EfiRuntimeServicesCode ||
- desc->Type == EfiRuntimeServicesData )
- desc->VirtualStart = desc->PhysicalStart;
- else
- desc->VirtualStart = INVALID_VIRTUAL_ADDRESS;
- }
- status = efi_rs->SetVirtualAddressMap(efi_memmap_size, efi_mdesc_size,
- mdesc_ver, efi_memmap);
- if ( status != EFI_SUCCESS )
- {
- printk(XENLOG_ERR "EFI: SetVirtualAddressMap() failed (%#lx),
disabling runtime services\n",
- status);
- __clear_bit(EFI_RS, &efi_flags);
+ /*
+ * Runtime services regions are always mapped here.
+ * Attributes may be adjusted in efi_init_memory().
+ */
+ if ( (desc->Attribute & EFI_MEMORY_RUNTIME) ||
+ desc->Type == EfiRuntimeServicesCode ||
+ desc->Type == EfiRuntimeServicesData )
+ desc->VirtualStart = desc->PhysicalStart;
+ else
+ desc->VirtualStart = INVALID_VIRTUAL_ADDRESS;
+ }
+ status = efi_rs->SetVirtualAddressMap(efi_memmap_size, efi_mdesc_size,
+ mdesc_ver, efi_memmap);
+ if ( status != EFI_SUCCESS )
+ {
+ printk(XENLOG_ERR
+ "EFI: SetVirtualAddressMap() failed (%#lx), disabling
runtime services\n",
+ status);
+ __clear_bit(EFI_RS, &efi_flags);
+ }
}
-#endif
/* Adjust pointers into EFI. */
efi_ct = (const void *)efi_ct + DIRECTMAP_VIRT_START;
--
generated by git-patchbot for /home/xen/git/xen.git#staging
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |