[xen staging] tools/tests/x86_emulator: avoid duplicate symbol error with clang: use -Og

[patchbot@xxxxxxx]

commit 442f3481fe3979e3e563bd7d221498a3d52133cc
Author:     Edwin Török <edwin.torok@xxxxxxxxxx>
AuthorDate: Tue Mar 10 09:28:09 2026 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Mar 10 09:28:09 2026 +0100

    tools/tests/x86_emulator: avoid duplicate symbol error with clang: use -Og
    
    clang would duplicate the loop body and end up with a double definition
    of the symbol:
    ```
    /tmp/test_x86_emulator-0f3576.s:27823: Error: symbol `vmovsh_to_mem' is 
already defined
    /tmp/test_x86_emulator-0f3576.s:27825: Error: symbol `.Lvmovsh_to_mem_end' 
is already defined
    ```
    
    Until a better solution is found: reduce optimizations in the test runner.
    
    Using -Os might also work, but we can't rely on the size optimization
    always avoiding the duplication of asm blocks.
    This is test code, not performance critical code, and -O0 is more future
    proof.
    However for debugging -Og is recommended over -O0, and this still avoids
    the duplicate label problem.
    
    Signed-off-by: Edwin Török <edwin.torok@xxxxxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 tools/tests/x86_emulator/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/tests/x86_emulator/Makefile 
b/tools/tests/x86_emulator/Makefile
index 5003c464f3..8210e83345 100644
--- a/tools/tests/x86_emulator/Makefile
+++ b/tools/tests/x86_emulator/Makefile
@@ -323,4 +323,11 @@ x86-emulate.o x86_emulate/%.o: HOSTCFLAGS += 
-D__XEN_TOOLS__
 $(call cc-option-add,HOSTCFLAGS-toplevel,HOSTCC,-fno-toplevel-reorder)
 test_x86_emulator.o: HOSTCFLAGS += $(HOSTCFLAGS-toplevel)
 
+# When unrolling loops, compilers may duplicate inline assembly. put_insn()
+# emits labels, which may not be emitted multiple times.
+# The default HOSTCFLAGS from $(XEN_ROOT)/Config.mk would set a non-zero
+# optimisation level.
+# Until a better solution is found: reduce optimizations in the test runner.
+test_x86_emulator.o: HOSTCFLAGS += -Og
+
 test_x86_emulator.o: $(addsuffix .h,$(TESTCASES)) $(addsuffix 
-opmask.h,$(OPMASK))
--
generated by git-patchbot for /home/xen/git/xen.git#staging