[xen master] x86/shadow: Rework write_atomic() call in shadow_write_entries()

[patchbot@xxxxxxx]

commit 495d470d9fdce210529c0aba16ff469ae0fbe952
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Sat Jan 3 21:28:52 2026 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Wed Feb 25 16:06:04 2026 +0000

    x86/shadow: Rework write_atomic() call in shadow_write_entries()
    
    ECLAIR reports an unevaluated side effect in a sizeof() expression (R13.6
    violation).
    
    write_atomic() does take care to evaluates each parameter only once, but
    expression is complicated to follow.  Rewrite it to less resemble an entry
    from an obfuscation contest.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
 xen/arch/x86/mm/shadow/set.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/mm/shadow/set.c b/xen/arch/x86/mm/shadow/set.c
index 8f9690f0df..2d02e1434c 100644
--- a/xen/arch/x86/mm/shadow/set.c
+++ b/xen/arch/x86/mm/shadow/set.c
@@ -62,8 +62,8 @@ shadow_write_entries(void *d, const void *s, unsigned int 
entries, mfn_t mfn)
 
     ASSERT(IS_ALIGNED((unsigned long)dst, sizeof(*dst)));
 
-    for ( ; i < entries; i++ )
-        write_atomic(&dst++->l1, src++->l1);
+    for ( ; i < entries; i++, dst++, src++ )
+        write_atomic(&dst->l1, src->l1);
 
     unmap_domain_page(map);
 }
--
generated by git-patchbot for /home/xen/git/xen.git#master