|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] x86/shadow: don't generate bogus "domain dying" trace entry from sh_page_fault()
commit cbfed8361b679676193f4dfe366fe39992566c51
Author: Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Mon Feb 23 08:38:07 2026 +0100
Commit: Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Mon Feb 23 08:38:07 2026 +0100
x86/shadow: don't generate bogus "domain dying" trace entry from
sh_page_fault()
When in 3-level guest mode we help a guest to stay alive, we also
shouldn't emit a trace entry to the contrary. Move the invocation up
into the respective #ifdef, noting that while this moves it into the
locked region, emitting trace records with the paging lock held is okay
(as done elsewhere as well), just needlessly increasing lock holding
time a little.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
xen/arch/x86/mm/shadow/multi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c
index e13cc602b9..b63046fd4f 100644
--- a/xen/arch/x86/mm/shadow/multi.c
+++ b/xen/arch/x86/mm/shadow/multi.c
@@ -2483,10 +2483,10 @@ static int cf_check sh_page_fault(
sh_update_cr3(v, false);
#else
ASSERT(d->is_shutting_down);
+ sh_trace_va(TRC_SHADOW_DOMF_DYING, va);
#endif
paging_unlock(d);
put_gfn(d, gfn_x(gfn));
- sh_trace_va(TRC_SHADOW_DOMF_DYING, va);
return 0;
}
--
generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |