[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] xen: Use MFLAGS for silent-mode detection



commit f2a31b7d7c80bcba40c6adb88668aa2733c68ad2
Author:     Bertrand Marquis <bertrand.marquis@xxxxxxx>
AuthorDate: Tue Feb 10 10:22:53 2026 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Feb 10 10:22:53 2026 +0100

    xen: Use MFLAGS for silent-mode detection
    
    GNU make 4.4+ exposes variable overrides in MAKEFLAGS after "--" (e.g.
    O=/path, FOO=bar). The silent-mode check searches for "s" and can match
    an override value, forcing silent output even without -s.
    
    Use MFLAGS for short options and filter out any long options before
    searching for "s". This preserves -s detection while avoiding false
    positives from overrides.
    
    Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/Makefile | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/xen/Makefile b/xen/Makefile
index 31352d4cd2..a054315fa4 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -113,10 +113,11 @@ else
     Q := @
 endif
 
-# If the user is running make -s (silent mode), suppress echoing of
-# commands
-
-ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
+# If the user is running make -s (silent mode), suppress echoing of commands.
+# Use MFLAGS (options only). MAKEFLAGS may include variable overrides after
+# â??--â?? (GNU make 4.4 and newer), which can contain an â??sâ?? and falsely 
trigger
+# silent mode.
+ifneq ($(findstring s,$(filter-out --%,$(MFLAGS))),)
     quiet := silent_
 endif
 
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.