[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] x86/HPET: drop "long timeout" handling from reprogram_hpet_evt_channel()



commit ae8a5165d644eae9209672d035d80086e05ad443
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Thu Jan 22 14:12:14 2026 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Jan 22 16:06:22 2026 +0100

    x86/HPET: drop "long timeout" handling from reprogram_hpet_evt_channel()
    
    Neither caller passes STIME_MAX, so (bogusly) handling the case isn't
    necessary.
    
    "Bogusly" because with 32-bit counters, writing 0 means on average half
    the wrapping period until an interrupt would be raised, while of course
    in extreme cases an interrupt would be raised almost right away.
    
    Leave an assertion.
    
    Amends: aa42fc0e9cd9 ("cpuidle: remove hpet access in hpet_broadcast_exit")
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 xen/arch/x86/hpet.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index 44915d9ecb..368c6eb4a0 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -162,12 +162,7 @@ static int reprogram_hpet_evt_channel(
 
     ch->next_event = expire;
 
-    if ( expire == STIME_MAX )
-    {
-        /* We assume it will take a long time for the timer to wrap. */
-        hpet_write32(0, HPET_Tn_CMP(ch->idx));
-        return 0;
-    }
+    ASSERT(expire != STIME_MAX);
 
     delta = min_t(int64_t, delta, MAX_DELTA_NS);
     delta = max_t(int64_t, delta, MIN_DELTA_NS);
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.