|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] MISRA: Extend the R3.1 deviation for URLs to include git://
commit fe0ede8fe4ac19f6b5f8ab3428f78d1c19fc3f71
Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Wed Jan 7 12:42:07 2026 +0000
Commit: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Fri Jan 9 14:24:24 2026 +0000
MISRA: Extend the R3.1 deviation for URLs to include git://
xen/drivers/passthrough/arm/ipmmu-vmsa.c contains a git:// URL in a block
comment. This is also not an example of commented out code, so shouldn't be
considered a R3.1 violation.
Extend the regex to include git://, and swap hyperlink for URL in the
associated documentation to be more precise.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
automation/eclair_analysis/ECLAIR/deviations.ecl | 4 ++--
docs/misra/deviations.rst | 4 ++--
docs/misra/rules.rst | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl
b/automation/eclair_analysis/ECLAIR/deviations.ecl
index 7dee4a488d..30c3239069 100644
--- a/automation/eclair_analysis/ECLAIR/deviations.ecl
+++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
@@ -58,9 +58,9 @@ removed by the compiler, the resulting slowdown is
negligible."
# Series 3.
#
--doc_begin="Comments starting with '/*' and containing hyperlinks are safe as
+-doc_begin="Comments starting with '/*' and containing URLs are safe as
they are not instances of commented-out code."
--config=MC3A2.R3.1,reports+={safe, "first_area(text(^.*https?://.*$))"}
+-config=MC3A2.R3.1,reports+={safe, "first_area(text(^.*(https?|git)://.*$))"}
-doc_end
#
diff --git a/docs/misra/deviations.rst b/docs/misra/deviations.rst
index 0d90f5886e..17c21537f2 100644
--- a/docs/misra/deviations.rst
+++ b/docs/misra/deviations.rst
@@ -117,8 +117,8 @@ Deviations related to MISRA C:2012 Rules:
- Tagged as `deliberate` for ECLAIR.
* - R3.1
- - Comments starting with '/\*' and containing hyperlinks are safe as they
- are not instances of commented-out code.
+ - Comments starting with '/\*' and containing URLs are safe as they are
+ not instances of commented-out code.
- Tagged as `safe` for ECLAIR.
* - R5.3
diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst
index 4e94251887..b3e929307d 100644
--- a/docs/misra/rules.rst
+++ b/docs/misra/rules.rst
@@ -143,7 +143,7 @@ maintainers if you want to suggest a change.
- Required
- The character sequences /* and // shall not be used within a
comment
- - Comments containing hyperlinks inside C-style block comments are safe
+ - Comments containing URLs inside C-style block comments are safe
* - `Rule 3.2
<https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_03_02.c>`_
- Required
--
generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |