|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen staging] xen/domain: Disallow XENMEM_claim_pages on dying domains
commit 2379ca04feab7df40051d03f73487d9e0cef43ac
Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Mon Dec 15 18:45:33 2025 +0000
Commit: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Wed Dec 17 17:35:24 2025 +0000
xen/domain: Disallow XENMEM_claim_pages on dying domains
XENMEM_claim_pages can be issued on a domain in the later stages of
domain_kill(). In that case, the claimed memory is leaked, as there's no
way
to subsequently release the claim.
Claims are intended for use during domain construction; to reserve
sufficient
RAM to construct the domain fully. There's no legitimate reason to be
calling
it on a dying domain.
Fixes: 65c9792df600 ("mmu: Introduce XENMEM_claim_pages (subop of memory
ops)")
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
xen/common/memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xen/common/memory.c b/xen/common/memory.c
index 3688e6dd50..ae805ccbe4 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -1681,6 +1681,9 @@ long do_memory_op(unsigned long cmd,
XEN_GUEST_HANDLE_PARAM(void) arg)
rc = xsm_claim_pages(XSM_PRIV, d);
+ if ( !rc && d->is_dying )
+ rc = -EINVAL;
+
if ( !rc )
rc = domain_set_outstanding_pages(d, reservation.nr_extents);
--
generated by git-patchbot for /home/xen/git/xen.git#staging
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |