[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] tools/sd-notify.h: Include string.h too



commit 8efff5a69ab7596f6c63031d0aef292114948cd9
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Fri Dec 5 21:33:25 2025 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Fri Dec 12 03:04:48 2025 +0000

    tools/sd-notify.h: Include string.h too
    
    Alpine Linux, when using --enable-systemd to get the init files, fails with:
    
      tools/include/xen-sd-notify.h:69:3: error: call to undeclared library
      function 'memcpy' with type 'void *(void *, const void *, unsigned long)';
      ISO C99 and later do not support implicit function declarations
      [-Wimplicit-function-declaration]
         69 |   memcpy(socket_addr.sun.sun_path, socket_path, path_length);
            |   ^
    
    This will be down to using musl rather than glibc.  Include the appropriate
    header.
    
    Fixes: 78510f3a1522 ("tools: Import stand-alone sd_notify() implementation 
from systemd")
    Reported-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
    Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
---
 tools/include/xen-sd-notify.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/include/xen-sd-notify.h b/tools/include/xen-sd-notify.h
index 28c9b20f15..20441d0ec9 100644
--- a/tools/include/xen-sd-notify.h
+++ b/tools/include/xen-sd-notify.h
@@ -20,6 +20,7 @@
 #include <errno.h>
 #include <stddef.h>
 #include <stdlib.h>
+#include <string.h>
 #include <sys/socket.h>
 #include <sys/un.h>
 #include <unistd.h>
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.