[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging-4.20] x86/hvm/ioreq: Fix condition in hvm_alloc_legacy_ioreq_gfn()



commit cb827d83175e41e1aa3f6a4de1ef5a88f91dc16a
Author:     Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
AuthorDate: Wed Sep 3 13:56:04 2025 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Sep 3 13:56:04 2025 +0200

    x86/hvm/ioreq: Fix condition in hvm_alloc_legacy_ioreq_gfn()
    
    Fix the incorrect condition that causes hvm_alloc_legacy_ioreq_gfn()
    to return INVALID_GFN even if the HVM param was installed properly by
    the toolstack.
    
    Fixes: 3486f398a3dd (' x86/hvm/ioreq: allow ioreq servers to use 
HVM_PARAM_[BUF]IOREQ_PFN')
    Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
    master commit: 282ed258a59195698a81ab4408a17336eb6ea7ed
    master date: 2025-08-18 10:43:52 +0200
---
 xen/arch/x86/hvm/ioreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
index d6491df8e7..c1c9da819d 100644
--- a/xen/arch/x86/hvm/ioreq.c
+++ b/xen/arch/x86/hvm/ioreq.c
@@ -63,7 +63,7 @@ static gfn_t hvm_alloc_legacy_ioreq_gfn(struct ioreq_server 
*s)
 
     for ( i = HVM_PARAM_IOREQ_PFN; i <= HVM_PARAM_BUFIOREQ_PFN; i++ )
     {
-        if ( !test_and_clear_bit(i, &d->arch.hvm.ioreq_gfn.legacy_mask) )
+        if ( test_and_clear_bit(i, &d->arch.hvm.ioreq_gfn.legacy_mask) )
             return _gfn(d->arch.hvm.params[i]);
     }
 
--
generated by git-patchbot for /home/xen/git/xen.git#staging-4.20



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.