[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] x86: introduce "hot" and "cold" page copying functions
commit fc1556a1a6fa57c1de1f7a571dab06323b8b7254 Author: Jan Beulich <jbeulich@xxxxxxxx> AuthorDate: Mon Sep 1 11:14:32 2025 +0200 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Mon Sep 1 13:07:01 2025 +0200 x86: introduce "hot" and "cold" page copying functions The present copy_page_sse2() is useful in case the destination page isn't going to get touched again soon, or if we want to limit churn on the caches. Just rename it, to fit the corresponding {clear,scrub}_page_*() naming scheme. For cases where latency is the most important aspect, or when it is expected that sufficiently large parts of a destination page will get accessed again soon after the copying, introduce a "hot" alternative. Again use alternatives patching to select between a "legacy" and an ERMS variant. Don't switch any callers just yet - this will be the subject of subsequent changes. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx> --- xen/arch/x86/copy_page.S | 19 +++++++++++++++++-- xen/arch/x86/include/asm/page.h | 5 +++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/copy_page.S b/xen/arch/x86/copy_page.S index e43e5370c8..0e09f0824a 100644 --- a/xen/arch/x86/copy_page.S +++ b/xen/arch/x86/copy_page.S @@ -13,7 +13,7 @@ #define tmp3_reg %r10 #define tmp4_reg %r11 -FUNC(copy_page_sse2) +FUNC(copy_page_cold) mov $PAGE_SIZE/(4*WORD_SIZE)-3, %ecx prefetchnta 2*4*WORD_SIZE(src_reg) @@ -44,4 +44,19 @@ FUNC(copy_page_sse2) sfence RET -END(copy_page_sse2) +END(copy_page_cold) + + .macro copy_page_movsb + mov $PAGE_SIZE, %ecx + rep movsb + .endm + + .macro copy_page_movsq + mov $PAGE_SIZE/8, %ecx + rep movsq + .endm + +FUNC(copy_page_hot) + ALTERNATIVE copy_page_movsq, copy_page_movsb, X86_FEATURE_ERMS + RET +END(copy_page_hot) diff --git a/xen/arch/x86/include/asm/page.h b/xen/arch/x86/include/asm/page.h index 079ec88cc5..65a01f2402 100644 --- a/xen/arch/x86/include/asm/page.h +++ b/xen/arch/x86/include/asm/page.h @@ -221,10 +221,11 @@ typedef struct { u64 pfn; } pagetable_t; void clear_page_hot(void *pg); void clear_page_cold(void *pg); -void copy_page_sse2(void *to, const void *from); +void copy_page_hot(void *to, const void *from); +void copy_page_cold(void *to, const void *from); #define clear_page(_p) clear_page_cold(_p) -#define copy_page(_t, _f) copy_page_sse2(_t, _f) +#define copy_page(_t, _f) copy_page_cold(_t, _f) #ifdef CONFIG_DEBUG void scrub_page_hot(void *ptr); -- generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |