[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] xen/x86: Disallow creating domains with altp2m enabled and altp2m.nr == 0



commit ae81cfa4d4a2717c5a151f4d1d1bbeb56523395a
Author:     Petr Beneš <w1benny@xxxxxxxxx>
AuthorDate: Mon Aug 25 12:51:10 2025 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Mon Aug 25 12:51:10 2025 +0200

    xen/x86: Disallow creating domains with altp2m enabled and altp2m.nr == 0
    
    Since libxl finally sends the altp2m.nr value, we can remove the previously
    introduced temporary workaround.
    
    Creating domain with enabled altp2m while setting altp2m.nr == 0 doesn't
    make sense and it's probably not what user wants.
    
    Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/domain.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index fc7ede0705..19fd86ce88 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -741,8 +741,9 @@ int arch_sanitise_domain_config(struct 
xen_domctl_createdomain *config)
 
         if ( !config->altp2m.nr )
         {
-            /* Fix the value to the legacy default */
-            config->altp2m.nr = 10;
+            dprintk(XENLOG_INFO,
+                    "altp2m must be requested with altp2m.nr > 0\n");
+            return -EINVAL;
         }
 
         if ( config->altp2m.nr > MAX_NR_ALTP2M )
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.