[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] tools/xenstored: fix possible NULL deref



commit f3365a6bfd2142b067fb2c78fcb8b35d2e5d40e1
Author:     Juergen Gross <jgross@xxxxxxxx>
AuthorDate: Thu Aug 21 12:49:25 2025 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Aug 21 12:49:25 2025 +0200

    tools/xenstored: fix possible NULL deref
    
    Avoid dereferencing NULL in introduce_domain() when called during
    live update.
    
    Coverity ID: 1665111
    Fixes: f78895ad78c9 ("tools/xenstored: Read event channel from xenstored 
page")
    Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
    Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
---
 tools/xenstored/domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xenstored/domain.c b/tools/xenstored/domain.c
index 694d68670a..5ce539d640 100644
--- a/tools/xenstored/domain.c
+++ b/tools/xenstored/domain.c
@@ -1032,7 +1032,7 @@ static struct domain *introduce_domain(const void *ctx,
                if (!interface && !restore)
                        return NULL;
 
-               if (interface->evtchn_port)
+               if (!restore && interface->evtchn_port)
                        port = interface->evtchn_port;
 
                if (new_domain(domain, port, restore)) {
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.