[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen staging] xen/keyhandler: add missing noreturn attribute
commit 9ea5d035db82fc6cada253af417440f577ba35cb Author: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> AuthorDate: Fri Jun 6 14:27:07 2025 -0700 Commit: Stefano Stabellini <stefano.stabellini@xxxxxxx> CommitDate: Wed Jun 18 17:40:41 2025 -0700 xen/keyhandler: add missing noreturn attribute Function `reboot_machine' does not return, but lacks the `noreturn' attribute. Functions that never return should be declared with a `noreturn' attribute. The lack of `noreturn' causes a violation of MISRA C Rule 17.11 (not currently accepted in Xen), and also Rule 2.1: "A project shall not contain unreachable code". Depending on the compiler used and the compiler optimization used, the lack of `noreturn' might lead to the presence of unreachable code. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> Signed-off-by: Victor Lira <victorm.lira@xxxxxxx> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx> --- xen/common/keyhandler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c index 0bb842ec00..b0a2051408 100644 --- a/xen/common/keyhandler.c +++ b/xen/common/keyhandler.c @@ -251,7 +251,7 @@ static void cf_check dump_hwdom_registers(unsigned char key) } } -static void cf_check reboot_machine(unsigned char key, bool unused) +static void noreturn cf_check reboot_machine(unsigned char key, bool unused) { printk("'%c' pressed -> rebooting machine\n", key); machine_restart(0); -- generated by git-patchbot for /home/xen/git/xen.git#staging
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |