|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen staging-4.19] x86/pmstat: correct get_cpufreq_para()'s error return value
commit 46da7056e4a043a995b733357219a38b50c25911
Author: Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Thu Mar 27 15:06:45 2025 +0100
Commit: Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Mar 27 15:06:45 2025 +0100
x86/pmstat: correct get_cpufreq_para()'s error return value
copy_to_guest() returns the number of bytes not copied; that's not what
the function should return to its caller though. Convert to returning
-EFAULT instead.
Fixes: 7542c4ff00f2 ("Add user PM control interface")
Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
master commit: 855337ca4947508ffca23393e291c54b5307cc9a
master date: 2025-03-27 12:22:06 +0100
---
xen/drivers/acpi/pmstat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/drivers/acpi/pmstat.c b/xen/drivers/acpi/pmstat.c
index 998d2e3c65..f607bc110f 100644
--- a/xen/drivers/acpi/pmstat.c
+++ b/xen/drivers/acpi/pmstat.c
@@ -227,7 +227,7 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)
affected_cpus, op->u.get_para.cpu_num);
xfree(affected_cpus);
if ( ret )
- return ret;
+ return -EFAULT;
if ( !(scaling_available_frequencies =
xzalloc_array(uint32_t, op->u.get_para.freq_num)) )
@@ -239,7 +239,7 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)
scaling_available_frequencies, op->u.get_para.freq_num);
xfree(scaling_available_frequencies);
if ( ret )
- return ret;
+ return -EFAULT;
op->u.get_para.cpuinfo_cur_freq =
cpufreq_driver.get ? alternative_call(cpufreq_driver.get, op->cpuid)
@@ -275,7 +275,7 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)
gov_num * CPUFREQ_NAME_LEN);
xfree(scaling_available_governors);
if ( ret )
- return ret;
+ return -EFAULT;
op->u.get_para.u.s.scaling_cur_freq = policy->cur;
op->u.get_para.u.s.scaling_max_freq = policy->max;
--
generated by git-patchbot for /home/xen/git/xen.git#staging-4.19
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |