[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] xen/ACPI: Drop local acpi_os_{v,}printf() and use plain {v,}printk()



commit a38b4d64fc36004c522d96b01998693f249b6cb0
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Mon Feb 17 19:13:01 2025 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Tue Feb 25 13:30:55 2025 +0000

    xen/ACPI: Drop local acpi_os_{v,}printf() and use plain {v,}printk()
    
    Now that Xen has a real vprintk(), there's no need to opencode it locally 
with
    vsnprintf().  Redirect the debug routines to the real {v,}printk() and drop
    the local acpi_os_{v,}printf() implementations.
    
    Amongst other things, this removes one arbitrary limit on message size, as
    well as removing a 512 byte static buffer that ought to have been in
    __initdata given that is private to an __init function.
    
    No functional change.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/drivers/acpi/osl.c      | 17 -----------------
 xen/include/acpi/acpiosxf.h |  5 ++---
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/xen/drivers/acpi/osl.c b/xen/drivers/acpi/osl.c
index ab80d6b2a9..7f233bab42 100644
--- a/xen/drivers/acpi/osl.c
+++ b/xen/drivers/acpi/osl.c
@@ -45,23 +45,6 @@ ACPI_MODULE_NAME("osl")
 #include CONFIG_ACPI_CUSTOM_DSDT_FILE
 #endif
 
-void __init acpi_os_printf(const char *fmt, ...)
-{
-       va_list args;
-       va_start(args, fmt);
-       acpi_os_vprintf(fmt, args);
-       va_end(args);
-}
-
-void __init acpi_os_vprintf(const char *fmt, va_list args)
-{
-       static char buffer[512];
-
-       vsnprintf(buffer, sizeof(buffer), fmt, args);
-
-       printk("%s", buffer);
-}
-
 acpi_physical_address __initdata rsdp_hint;
 
 acpi_physical_address __init acpi_os_get_root_pointer(void)
diff --git a/xen/include/acpi/acpiosxf.h b/xen/include/acpi/acpiosxf.h
index de83ea38c4..2da318962f 100644
--- a/xen/include/acpi/acpiosxf.h
+++ b/xen/include/acpi/acpiosxf.h
@@ -82,8 +82,7 @@ acpi_os_write_memory(acpi_physical_address address, u32 
value, u32 width);
 /*
  * Debug print routines
  */
-void ACPI_INTERNAL_VAR_XFACE acpi_os_printf(const char *format, ...);
-
-void acpi_os_vprintf(const char *format, va_list args);
+#define acpi_os_printf printk
+#define acpi_os_vprintf vprintk
 
 #endif                         /* __ACPIOSXF_H__ */
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.