[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging] AMD/IOMMU: drop stray MSI enabling



commit 83187a21fd9bc26e23472ea351153ff8f7c2a7b8
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Feb 4 13:50:49 2025 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Feb 4 13:50:49 2025 +0100

    AMD/IOMMU: drop stray MSI enabling
    
    While the 2nd of the commits referenced below should have moved the call
    to amd_iommu_msi_enable() instead of adding another one, the situation
    wasn't quite right even before: It can't have done any good to enable
    MSI when no IRQ was allocated for it, yet.
    
    The other call to amd_iommu_msi_enable(), just out of patch context,
    needs to stay there until S3 resume is re-worked. For the boot path that
    call should be unnecessary, as iommu{,_maskable}_msi_startup() will have
    done it already (by way of invoking iommu_msi_unmask()).
    
    Fixes: 5f569f1ac50e ("AMD/IOMMU: allow enabling with IRQ not yet set up")
    Fixes: d9e49d1afe2e ("AMD/IOMMU: adjust setup of internal interrupt for 
x2APIC mode")
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
    Tested-by: Jason Andryuk <jason.andryuk@xxxxxxx>
    Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@xxxxxxxxx>
---
 xen/drivers/passthrough/amd/iommu_init.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xen/drivers/passthrough/amd/iommu_init.c 
b/xen/drivers/passthrough/amd/iommu_init.c
index 3023625020..05fd3bde6e 100644
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -902,8 +902,6 @@ static void enable_iommu(struct amd_iommu *iommu)
         }
     }
 
-    amd_iommu_msi_enable(iommu, IOMMU_CONTROL_ENABLED);
-
     set_iommu_ht_flags(iommu);
     set_iommu_command_buffer_control(iommu, IOMMU_CONTROL_ENABLED);
 
--
generated by git-patchbot for /home/xen/git/xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.