[xen staging] x86/msi: fix Misra Rule 20.7 in msi.h

[patchbot@xxxxxxx]

commit 488579e956e086c21bc6750b1b77eb0efd22cfa2
Author:     Roger Pau Monné <roger.pau@xxxxxxxxxx>
AuthorDate: Tue Nov 19 11:34:42 2024 +0100
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Tue Nov 19 19:53:51 2024 +0000

    x86/msi: fix Misra Rule 20.7 in msi.h
    
    Adjust the macros to parenthesize their arguments.  Use
    MASK_EXTR()/MASK_INSR() where appropriate.
    
    No functional change intended.
    
    Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/include/asm/msi.h | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/xen/arch/x86/include/asm/msi.h b/xen/arch/x86/include/asm/msi.h
index 62a40e7298..63adb19820 100644
--- a/xen/arch/x86/include/asm/msi.h
+++ b/xen/arch/x86/include/asm/msi.h
@@ -147,26 +147,26 @@ int msi_free_irq(struct msi_desc *entry);
  */
 #define NR_HP_RESERVED_VECTORS         20
 
-#define msi_control_reg(base)          (base + PCI_MSI_FLAGS)
-#define msi_lower_address_reg(base)    (base + PCI_MSI_ADDRESS_LO)
-#define msi_upper_address_reg(base)    (base + PCI_MSI_ADDRESS_HI)
+#define msi_control_reg(base)          ((base) + PCI_MSI_FLAGS)
+#define msi_lower_address_reg(base)    ((base) + PCI_MSI_ADDRESS_LO)
+#define msi_upper_address_reg(base)    ((base) + PCI_MSI_ADDRESS_HI)
 #define msi_data_reg(base, is64bit)    \
-       ( (is64bit == 1) ? base+PCI_MSI_DATA_64 : base+PCI_MSI_DATA_32 )
+       ((base) + ((is64bit) ? PCI_MSI_DATA_64 : PCI_MSI_DATA_32))
 #define msi_mask_bits_reg(base, is64bit) \
-       ( (is64bit == 1) ? base+PCI_MSI_MASK_BIT : base+PCI_MSI_MASK_BIT-4)
+       ((base) + PCI_MSI_MASK_BIT - ((is64bit) ? 0 : 4))
 #define msi_pending_bits_reg(base, is64bit) \
        ((base) + PCI_MSI_MASK_BIT + ((is64bit) ? 4 : 0))
 #define multi_msi_capable(control) \
-       (1 << ((control & PCI_MSI_FLAGS_QMASK) >> 1))
+       (1U << MASK_EXTR(control, PCI_MSI_FLAGS_QMASK))
 #define multi_msi_enable(control, num) \
-       control |= (((fls(num) - 1) << 4) & PCI_MSI_FLAGS_QSIZE);
-#define is_64bit_address(control)      (!!(control & PCI_MSI_FLAGS_64BIT))
-#define is_mask_bit_support(control)   (!!(control & PCI_MSI_FLAGS_MASKBIT))
-
-#define msix_control_reg(base)         (base + PCI_MSIX_FLAGS)
-#define msix_table_offset_reg(base)    (base + PCI_MSIX_TABLE)
-#define msix_pba_offset_reg(base)      (base + PCI_MSIX_PBA)
-#define msix_table_size(control)       ((control & PCI_MSIX_FLAGS_QSIZE)+1)
+       ((control) |= MASK_INSR(fls(num) - 1, PCI_MSI_FLAGS_QSIZE))
+#define is_64bit_address(control)      (!!((control) & PCI_MSI_FLAGS_64BIT))
+#define is_mask_bit_support(control)   (!!((control) & PCI_MSI_FLAGS_MASKBIT))
+
+#define msix_control_reg(base)         ((base) + PCI_MSIX_FLAGS)
+#define msix_table_offset_reg(base)    ((base) + PCI_MSIX_TABLE)
+#define msix_pba_offset_reg(base)      ((base) + PCI_MSIX_PBA)
+#define msix_table_size(control)       (((control) & PCI_MSIX_FLAGS_QSIZE) + 1)
 
 /*
  * MSI Defined Data Structures
--
generated by git-patchbot for /home/xen/git/xen.git#staging