[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] x86/pagewalk: Address MISRA R8.3 violation in guest_walk_tables()



commit b14dae96c07ef27cc7f8107ddaa16989e9ab024b
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Fri Jun 21 21:57:59 2024 +0100
Commit:     Stefano Stabellini <stefano.stabellini@xxxxxxx>
CommitDate: Mon Jun 24 16:42:51 2024 -0700

    x86/pagewalk: Address MISRA R8.3 violation in guest_walk_tables()
    
    Commit 4c5d78a10dc8 ("x86/pagewalk: Re-implement the pagetable walker")
    intentionally renamed guest_walk_tables()'s 'pfec' parameter to 'walk' 
because
    it's not a PageFault Error Code, despite the name of some of the constants
    passed in.  Sadly the constants-cleanup I've been meaning to do since then
    still hasn't come to pass.
    
    Update the declaration to match, to placate MISRA.
    
    Fixes: 4c5d78a10dc8 ("x86/pagewalk: Re-implement the pagetable walker")
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
    Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
---
 xen/arch/x86/include/asm/guest_pt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/include/asm/guest_pt.h 
b/xen/arch/x86/include/asm/guest_pt.h
index bc312343cd..7b0c9b005c 100644
--- a/xen/arch/x86/include/asm/guest_pt.h
+++ b/xen/arch/x86/include/asm/guest_pt.h
@@ -422,7 +422,7 @@ static inline unsigned int guest_walk_to_page_order(const 
walk_t *gw)
 
 bool
 guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m,
-                  unsigned long va, walk_t *gw, uint32_t pfec,
+                  unsigned long va, walk_t *gw, uint32_t walk,
                   gfn_t top_gfn, mfn_t top_mfn, void *top_map);
 
 /* Pretty-print the contents of a guest-walk */
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.