|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3
commit 166eb670e6f44b03b79e5751fcd0576553634150
Author: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
AuthorDate: Fri Aug 11 09:58:42 2023 +0200
Commit: Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Aug 11 09:58:42 2023 +0200
x86/vmsi: rename variables to address MISRA C:2012 Rule 5.3
The local variables 'irq_desc' shadow the homonymous global variable,
declared in 'xen/arch/x86/include/asm/irq.h', therefore they are renamed
'irqd'.
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
xen/arch/x86/hvm/vmsi.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c
index 3cd4923060..128f236362 100644
--- a/xen/arch/x86/hvm/vmsi.c
+++ b/xen/arch/x86/hvm/vmsi.c
@@ -462,7 +462,7 @@ static void del_msixtbl_entry(struct msixtbl_entry *entry)
int msixtbl_pt_register(struct domain *d, struct pirq *pirq, uint64_t gtable)
{
- struct irq_desc *irq_desc;
+ struct irq_desc *irqd;
struct msi_desc *msi_desc;
struct pci_dev *pdev;
struct msixtbl_entry *entry, *new_entry;
@@ -482,14 +482,14 @@ int msixtbl_pt_register(struct domain *d, struct pirq
*pirq, uint64_t gtable)
if ( !new_entry )
return -ENOMEM;
- irq_desc = pirq_spin_lock_irq_desc(pirq, NULL);
- if ( !irq_desc )
+ irqd = pirq_spin_lock_irq_desc(pirq, NULL);
+ if ( !irqd )
{
xfree(new_entry);
return r;
}
- msi_desc = irq_desc->msi_desc;
+ msi_desc = irqd->msi_desc;
if ( !msi_desc )
goto out;
@@ -508,7 +508,7 @@ found:
r = 0;
out:
- spin_unlock_irq(&irq_desc->lock);
+ spin_unlock_irq(&irqd->lock);
xfree(new_entry);
if ( !r )
@@ -533,7 +533,7 @@ out:
void msixtbl_pt_unregister(struct domain *d, struct pirq *pirq)
{
- struct irq_desc *irq_desc;
+ struct irq_desc *irqd;
struct msi_desc *msi_desc;
struct pci_dev *pdev;
struct msixtbl_entry *entry;
@@ -544,11 +544,11 @@ void msixtbl_pt_unregister(struct domain *d, struct pirq
*pirq)
if ( !msixtbl_initialised(d) )
return;
- irq_desc = pirq_spin_lock_irq_desc(pirq, NULL);
- if ( !irq_desc )
+ irqd = pirq_spin_lock_irq_desc(pirq, NULL);
+ if ( !irqd )
return;
- msi_desc = irq_desc->msi_desc;
+ msi_desc = irqd->msi_desc;
if ( !msi_desc )
goto out;
@@ -559,14 +559,14 @@ void msixtbl_pt_unregister(struct domain *d, struct pirq
*pirq)
goto found;
out:
- spin_unlock_irq(&irq_desc->lock);
+ spin_unlock_irq(&irqd->lock);
return;
found:
if ( !atomic_dec_and_test(&entry->refcnt) )
del_msixtbl_entry(entry);
- spin_unlock_irq(&irq_desc->lock);
+ spin_unlock_irq(&irqd->lock);
}
void msixtbl_init(struct domain *d)
--
generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |