|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] libxl: drop dead assignment to transaction variable from libxl__domain_make()
commit 87c621d0ef75e5f95987d66811ed1fd7129208d1
Author: Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Jun 14 12:32:10 2023 +0200
Commit: Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Jun 14 12:32:10 2023 +0200
libxl: drop dead assignment to transaction variable from
libxl__domain_make()
"t" is written first thing at the "retry_transaction" label.
Coverity ID: 1532321
Fixes: 1057300109ea ("libxl: fix error handling (xenstore transaction leak)
in libxl__domain_make")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
---
tools/libs/light/libxl_create.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index d7e80d5df7..393c535579 100644
--- a/tools/libs/light/libxl_create.c
+++ b/tools/libs/light/libxl_create.c
@@ -909,10 +909,8 @@ retry_transaction:
strlen(dom_type));
if (!xs_transaction_end(ctx->xsh, t, 0)) {
- if (errno == EAGAIN) {
- t = 0;
+ if (errno == EAGAIN)
goto retry_transaction;
- }
LOGED(ERROR, *domid, "domain creation ""xenstore transaction commit
failed");
rc = ERROR_FAIL;
goto out;
--
generated by git-patchbot for /home/xen/git/xen.git#master
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |