[xen stable-4.14] x86/vioapic: fix usage of index in place of GSI in vioapic_write_redirent

[patchbot@xxxxxxx]

commit 1d1d1f5391976456a79daac0dcfe7157da1e54f7
Author:     Roger Pau Monné <roge.rpau@xxxxxxxxxx>
AuthorDate: Tue Dec 1 15:34:55 2020 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Dec 1 15:34:55 2020 +0100

    x86/vioapic: fix usage of index in place of GSI in vioapic_write_redirent
    
    The usage of idx instead of the GSI in vioapic_write_redirent when
    accessing gsi_assert_count can cause a PVH dom0 with multiple
    vIO-APICs to lose interrupts in case a pin of a IO-APIC different than
    the first one is unmasked with pending interrupts.
    
    Switch to use gsi instead to fix the issue.
    
    Fixes: 9f44b08f7d0e4 ('x86/vioapic: introduce support for multiple vIO 
APICS')
    Reported-by: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
    Signed-off-by: Roger Pau Monné <roge.rpau@xxxxxxxxxx>
    Tested-by: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
    master commit: 3ae469af8e680df31eecd0a2ac6a83b58ad7ce53
    master date: 2020-11-30 14:06:38 +0100
---
 xen/arch/x86/hvm/vioapic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c
index b87facb0e0..52c5c636e3 100644
--- a/xen/arch/x86/hvm/vioapic.c
+++ b/xen/arch/x86/hvm/vioapic.c
@@ -260,7 +260,7 @@ static void vioapic_write_redirent(
         pent->fields.remote_irr = 0;
     else if ( !ent.fields.mask &&
               !ent.fields.remote_irr &&
-              hvm_irq->gsi_assert_count[idx] )
+              hvm_irq->gsi_assert_count[gsi] )
     {
         pent->fields.remote_irr = 1;
         vioapic_deliver(vioapic, idx);
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.14