[Xen-changelog] [xen master] EFI: fix "efi=attr=" handling

[patchbot@xxxxxxx]

commit 5530782cfe70ed22fe44358f6a10c38916443b42
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Nov 26 14:17:45 2019 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Nov 26 14:17:45 2019 +0100

    EFI: fix "efi=attr=" handling
    
    Commit 633a40947321 ("docs: Improve documentation and parsing for efi=")
    failed to honor the strcmp()-like return value convention of
    cmdline_strcmp().
    
    Reported-by: Roman Shaposhnik <roman@xxxxxxxxxx>
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Wei Liu <wl@xxxxxxx>
    Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
---
 xen/common/efi/boot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
index a8b6f39721..3f1c330afe 100644
--- a/xen/common/efi/boot.c
+++ b/xen/common/efi/boot.c
@@ -1430,9 +1430,9 @@ static int __init parse_efi_param(const char *s)
         }
         else if ( (ss - s) > 5 && !memcmp(s, "attr=", 5) )
         {
-            if ( cmdline_strcmp(s + 5, "uc") )
+            if ( !cmdline_strcmp(s + 5, "uc") )
                 efi_map_uc = true;
-            else if ( cmdline_strcmp(s + 5, "no") )
+            else if ( !cmdline_strcmp(s + 5, "no") )
                 efi_map_uc = false;
             else
                 rc = -EINVAL;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog