[Xen-changelog] [xen master] x86/vlapic: allow setting APIC_SPIV_FOCUS_DISABLED in x2APIC mode

[patchbot@xxxxxxx]

commit d7cd999faa1edf745a7597db811956cb882a5436
Author:     Roger Pau Monné <roger.pau@xxxxxxxxxx>
AuthorDate: Fri Nov 22 17:52:59 2019 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Nov 22 17:52:59 2019 +0100

    x86/vlapic: allow setting APIC_SPIV_FOCUS_DISABLED in x2APIC mode
    
    Current code unconditionally prevents setting APIC_SPIV_FOCUS_DISABLED
    regardless of the processor model, which is not correct according to
    the specification.
    
    This issue was discovered while trying to boot a pvshim with x2APIC
    enabled.
    
    Always allow setting APIC_SPIV_FOCUS_DISABLED: the local APIC
    provided to guests is emulated by Xen, and as such doesn't depend on
    the features found on the hardware processor. Note for example that
    Xen offers x2APIC support to guests even when the underlying hardware
    doesn't have such feature.
    
    Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
---
 xen/arch/x86/hvm/vlapic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index 9466258d6f..b790ba6bbd 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -993,6 +993,7 @@ int guest_wrmsr_x2apic(struct vcpu *v, uint32_t msr, 
uint64_t msr_content)
 
     case APIC_SPIV:
         if ( msr_content & ~(APIC_VECTOR_MASK | APIC_SPIV_APIC_ENABLED |
+                             APIC_SPIV_FOCUS_DISABLED |
                              (VLAPIC_VERSION & APIC_LVR_DIRECTED_EOI
                               ? APIC_SPIV_DIRECTED_EOI : 0)) )
             return X86EMUL_EXCEPTION;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog