[Xen-changelog] [xen master] libxl: Fix setting vncpasswd to empty string

[patchbot@xxxxxxx]

commit cda8f7e8576503b5e16fdf48d2630ad40cb7c7ef
Author:     Anthony PERARD <anthony.perard@xxxxxxxxxx>
AuthorDate: Mon Nov 4 15:30:47 2019 +0000
Commit:     Wei Liu <wl@xxxxxxx>
CommitDate: Tue Nov 12 10:39:01 2019 +0000

    libxl: Fix setting vncpasswd to empty string
    
    Before 93dcc22, error from setting the vnc password to an empty
    string, when QEMU wasn't expected a password, never prevented the creation
    of a guest, and only logged an error message.
    
    Reported-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Fixes: 93dcc22fe798c9fa5ce117f1ed6db0d8bd779020
    Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    Acked-by: Wei Liu <wl@xxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
---
 tools/libxl/libxl_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 7e52f09731..8e0fb78bd2 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -2936,7 +2936,7 @@ static void device_model_postconfig_vnc(libxl__egc *egc,
         if (rc) goto out;
     }
 
-    if (vnc && vnc->passwd) {
+    if (vnc && vnc->passwd && vnc->passwd[0]) {
         qmp->callback = device_model_postconfig_vnc_passwd;
         libxl__qmp_param_add_string(gc, &args, "password", vnc->passwd);
         rc = libxl__ev_qmp_send(gc, qmp, "change-vnc-password", args);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog