[Xen-changelog] [xen staging] x86/pv: Fix !CONFIG_PV build following XSA-299

[patchbot@xxxxxxx]

commit 7e4404f8c66f94ac173a3232712074677415d842
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Thu Oct 31 19:38:08 2019 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Fri Nov 1 10:48:04 2019 +0000

    x86/pv: Fix !CONFIG_PV build following XSA-299
    
    PTF_* are declared within CONFIG_PV, and used outside:
    
      mm.c: In function â??_put_page_typeâ??:
      mm.c:2819:32: error: â??PTF_preemptibleâ?? undeclared (first use in this 
function)
           bool preemptible = flags & PTF_preemptible;
                                      ^~~~~~~~~~~~~~~
      mm.c:2819:32: note: each undeclared identifier is reported only once for 
each
      function it appears in
      mm.c:2842:24: error: â??PTF_partial_setâ?? undeclared (first use in this 
function)
               if ( !(flags & PTF_partial_set) )
                              ^~~~~~~~~~~~~~~
      mm.c: In function â??put_page_type_preemptibleâ??:
      mm.c:3090:33: error: â??PTF_preemptibleâ?? undeclared (first use in this 
function)
           return _put_page_type(page, PTF_preemptible, NULL);
                                       ^~~~~~~~~~~~~~~
      mm.c: In function â??put_old_guest_tableâ??:
      mm.c:3108:25: error: â??PTF_preemptibleâ?? undeclared (first use in this 
function)
                               PTF_preemptible |
                               ^~~~~~~~~~~~~~~
      mm.c:3110:27: error: â??PTF_partial_setâ?? undeclared (first use in this 
function)
                                 PTF_partial_set : 0 ),
                                 ^~~~~~~~~~~~~~~
      mm.c: In function â??put_page_type_preemptibleâ??:
      mm.c:3091:1: error: control reaches end of non-void function
      [-Werror=return-type]
       }
       ^
      cc1: all warnings being treated as errors
    
    Re-position the definitions to be outside of the #ifdef CONFIG_PV
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Wei Liu <wl@xxxxxxx>
    Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
---
 xen/arch/x86/mm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 79c3e4c473..57f22775ac 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -1063,8 +1063,6 @@ get_page_from_l1e(
     return -EBUSY;
 }
 
-#ifdef CONFIG_PV
-
 /*
  * The following flags are used to specify behavior of various get and
  * put commands.  The first is also stored in page->partial_flags to
@@ -1077,6 +1075,8 @@ get_page_from_l1e(
 #define PTF_defer                 (1 << 3)
 #define PTF_retain_ref_on_restart (1 << 4)
 
+#ifdef CONFIG_PV
+
 static int get_page_and_type_from_mfn(
     mfn_t mfn, unsigned long type, struct domain *d,
     unsigned int flags)
--
generated by git-patchbot for /home/xen/git/xen.git#staging

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog