[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-xen master] s390-ccw: Fix alignment for CCW1



commit e1b4750f06a8a04c958d98e9a15e717b18a20c54
Author:     Farhan Ali <alifm@xxxxxxxxxxxxxxxxxx>
AuthorDate: Fri Aug 25 09:24:46 2017 -0400
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Tue Sep 12 11:24:49 2017 -0500

    s390-ccw: Fix alignment for CCW1
    
    The commit 198c0d1f9df8c4 s390x/css: check ccw address validity
    exposes an alignment issue in ccw bios.
    
    According to PoP the CCW must be doubleword aligned. Let's fix
    this in the bios.
    
    Cc: qemu-stable@xxxxxxxxxx
    Signed-off-by: Farhan Ali <alifm@xxxxxxxxxxxxxxxxxx>
    Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxxxxxxx>
    Reviewed-by: Eric Farman <farman@xxxxxxxxxxxxxxxxxx>
    Acked-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
    Message-Id: 
<3ed8b810b6592daee6a775037ce21f850e40647d.1503667215.git.alifm@xxxxxxxxxxxxxxxxxx>
    Signed-off-by: Cornelia Huck <cohuck@xxxxxxxxxx>
    (cherry picked from commit 3a1e4561ad63b303b092387ae006bd41468ece63)
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
---
 pc-bios/s390-ccw/cio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
index f5b4549..55eaeee 100644
--- a/pc-bios/s390-ccw/cio.h
+++ b/pc-bios/s390-ccw/cio.h
@@ -133,7 +133,7 @@ struct ccw1 {
     __u8 flags;
     __u16 count;
     __u32 cda;
-} __attribute__ ((packed));
+} __attribute__ ((packed, aligned(8)));
 
 #define CCW_FLAG_DC              0x80
 #define CCW_FLAG_CC              0x40
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.