[Xen-changelog] [xen master] build: enable no-parentheses in clang

[patchbot@xxxxxxx]

commit f827ab0390625cff1f20ee5e140605e173238e81
Author:     Roger Pau Monné <roger.pau@xxxxxxxxxx>
AuthorDate: Fri Feb 17 16:10:28 2017 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Feb 17 16:10:28 2017 +0100

    build: enable no-parentheses in clang
    
    And fix the following errors reported:
    
    traps.c:2014:25: error: equality comparison with extraneous parentheses
          [-Werror,-Wparentheses-equality]
            else if ( (port == RTC_PORT(0)) )
                       ~~~~~^~~~~~~~~~~~~~
    traps.c:2014:25: note: remove extraneous parentheses around the comparison 
to silence this warning
            else if ( (port == RTC_PORT(0)) )
                      ~     ^             ~
    traps.c:2014:25: note: use '=' to turn this equality comparison into an 
assignment
            else if ( (port == RTC_PORT(0)) )
                            ^~
                            =
    traps.c:2083:25: error: equality comparison with extraneous parentheses
          [-Werror,-Wparentheses-equality]
            else if ( (port == RTC_PORT(0)) )
                       ~~~~~^~~~~~~~~~~~~~
    
    Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 Config.mk            | 3 ---
 xen/arch/x86/traps.c | 4 ++--
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/Config.mk b/Config.mk
index bff4dc5..9a28d15 100644
--- a/Config.mk
+++ b/Config.mk
@@ -212,9 +212,6 @@ CFLAGS += -std=gnu99
 
 CFLAGS += -Wall -Wstrict-prototypes
 
-# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...'
-CFLAGS-$(clang) += -Wno-parentheses
-
 $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement)
 $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement)
 $(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable)
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index ae4a8fa..ec8b002 100644
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -2010,7 +2010,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int 
bytes,
         {
             sub_data = pv_pit_handler(port, 0, 0);
         }
-        else if ( (port == RTC_PORT(0)) )
+        else if ( port == RTC_PORT(0) )
         {
             sub_data = currd->arch.cmos_idx;
         }
@@ -2079,7 +2079,7 @@ void guest_io_write(unsigned int port, unsigned int 
bytes, uint32_t data,
         {
             pv_pit_handler(port, (uint8_t)data, 1);
         }
-        else if ( (port == RTC_PORT(0)) )
+        else if ( port == RTC_PORT(0) )
         {
             currd->arch.cmos_idx = data;
         }
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog