[Xen-changelog] [xen master] x86emul/test: don't use *_len symbols

[patchbot@xxxxxxx]

commit 9315fa0ef736d1153c98ce42bff5853da5ec697f
Author:     Jan Beulich <JBeulich@xxxxxxxx>
AuthorDate: Tue Jan 24 16:22:03 2017 +0000
Commit:     Wei Liu <wei.liu2@xxxxxxxxxx>
CommitDate: Tue Jan 24 16:22:03 2017 +0000

    x86emul/test: don't use *_len symbols
    
    ... as they don't work as intended with -fPIC.
    
    I did prefer them over *_end ones at the time because older gcc would
    cause .L* symbols to be public, due to issuing .globl for all
    referenced externals. And labels at the end of instructions collide
    with the ones at the start of the next instruction, making disassembly
    harder to grok. Luckily recent gcc no longer issues those .globl
    directives, and hence .L* labels, staying local by default, no longer
    get in the way.
    
    Reported-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    Tested-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 tools/tests/x86_emulator/test_x86_emulator.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/tools/tests/x86_emulator/test_x86_emulator.c 
b/tools/tests/x86_emulator/test_x86_emulator.c
index 245d1c6..924fd36 100644
--- a/tools/tests/x86_emulator/test_x86_emulator.c
+++ b/tools/tests/x86_emulator/test_x86_emulator.c
@@ -885,17 +885,16 @@ int main(int argc, char **argv)
     }
     printf("okay\n");
 
-#define decl_insn(which) extern const unsigned char which[], which##_len[]
+#define decl_insn(which) extern const unsigned char which[], \
+                         which##_end[] asm ( ".L" #which "_end" )
 #define put_insn(which, insn) ".pushsection .test, \"ax\", @progbits\n" \
                               #which ": " insn "\n"                     \
-                              ".equ " #which "_len, .-" #which "\n"     \
+                              ".L" #which "_end:\n"                     \
                               ".popsection"
 #define set_insn(which) (regs.eip = (unsigned long)(which))
 #define valid_eip(which) (regs.eip >= (unsigned long)(which) && \
-                          regs.eip < (unsigned long)(which) + \
-                                      (unsigned long)which##_len)
-#define check_eip(which) (regs.eip == (unsigned long)(which) + \
-                                      (unsigned long)which##_len)
+                          regs.eip < (unsigned long)which##_end)
+#define check_eip(which) (regs.eip == (unsigned long)which##_end)
 
     printf("%-40s", "Testing andn (%edx),%ecx,%ebx...");
     if ( stack_exec && cpu_has_bmi1 )
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog