[Xen-changelog] [xen master] x86/boot: fix build with certain older gcc versions

[patchbot@xxxxxxx]

commit 620b3c7eee78e90167f591877177c922ae619b92
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Fri Dec 16 14:37:35 2016 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Dec 16 14:37:35 2016 +0100

    x86/boot: fix build with certain older gcc versions
    
    Despite all attempts so far (ending in commit fecf584294 ["Config.mk:
    fix comment for debug option"] adjusting the respective comment),
    Config.mk's debug= setting still affects the hypervisor build: CFLAGS
    gets -g added there.
    
    xen/arch/x86/boot/build32.mk includes that file, and hence inherits the
    setting too. Some gcc versions take -g to create an .eh_frame section
    despite -fno-asynchronous-unwind-tables (which instead one would expect
    to produce .debug_frame).
    
    In turn, commit 93c0c0287a ("x86/boot: create *.lnk files with linker
    script") was - in my understanding - supposed to make sure .text is
    first, but apparently it did also not really achieve that effect: Both
    reloc.lnk and reloc.bin in the case here ended up with .eh_frame first,
    which obviously rendered the whole final binary unusable.
    
    Explicitly suppress generation of any kind of debug info when building
    reloc.o.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/boot/build32.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/boot/build32.mk b/xen/arch/x86/boot/build32.mk
index 39e6453..272d942 100644
--- a/xen/arch/x86/boot/build32.mk
+++ b/xen/arch/x86/boot/build32.mk
@@ -4,7 +4,7 @@ include $(XEN_ROOT)/Config.mk
 
 $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
 
-CFLAGS += -Werror -fno-asynchronous-unwind-tables -fno-builtin -msoft-float
+CFLAGS += -Werror -fno-asynchronous-unwind-tables -fno-builtin -g0 -msoft-float
 CFLAGS := $(filter-out -flto,$(CFLAGS)) 
 
 # NB. awk invocation is a portable alternative to 'head -n -1'
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog