[Xen-changelog] [xen master] xenstore: add assertion in database dumping code

[patchbot@xxxxxxx]

commit 368574c0b79b1e67b211fe7ad5d1bc1601b0c24b
Author:     Wei Liu <wei.liu2@xxxxxxxxxx>
AuthorDate: Wed Jul 20 15:13:42 2016 +0100
Commit:     Wei Liu <wei.liu2@xxxxxxxxxx>
CommitDate: Wed Jul 20 16:09:25 2016 +0100

    xenstore: add assertion in database dumping code
    
    If memfile is NULL, the signal handler won't be installed, hence fopen
    won't dereference NULL. Coverity is not smart enough to figure that out
    unfortunately.
    
    Add an assertion to prevent coverity from complaining.
    
    Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/xenstore/xenstored_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 5b2a49b..693d47d 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -2135,6 +2135,7 @@ int main(int argc, char *argv[])
                if (trigger_talloc_report) {
                        FILE *out;
 
+                       assert(memfile);
                        trigger_talloc_report = false;
                        out = fopen(memfile, "a");
                        if (out) {
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog