|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen master] libxl: Cleanup: use libxl__backendpath_parse_domid in libxl__device_disk_from_xs_be
commit 03273df2ecbe04bdb16dab1b6dacf8175a0fe84a
Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
AuthorDate: Thu Jun 2 16:10:31 2016 +0100
Commit: Wei Liu <wei.liu2@xxxxxxxxxx>
CommitDate: Thu Jun 2 16:35:02 2016 +0100
libxl: Cleanup: use libxl__backendpath_parse_domid in
libxl__device_disk_from_xs_be
Rather than an open-coded sscanf. No functional change with correct
input.
This is a followup to XSA-175 and XSA-178.
Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
tools/libxl/libxl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index d5475ed..006b83f 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -2658,10 +2658,10 @@ static int libxl__device_disk_from_xenstore(libxl__gc
*gc,
goto out;
}
- rc = sscanf(backend_path, "/local/domain/%d/", &disk->backend_domid);
- if (rc != 1) {
+ rc = libxl__backendpath_parse_domid(gc, backend_path,
&disk->backend_domid);
+ if (rc) {
LOG(ERROR, "Unable to fetch device backend domid from %s",
backend_path);
- goto cleanup;
+ goto out;
}
/*
--
generated by git-patchbot for /home/xen/git/xen.git#master
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |