[Xen-changelog] [xen stable-4.5] arm: Fix asynchronous aborts (SError exceptions) due to bogus PTEs

[patchbot@xxxxxxx]

commit d19f9412f2fe046247bc6bf68dc6a4c5129bfd41
Author:     Vikram Sethi <vikrams@xxxxxxxxxxxxxx>
AuthorDate: Mon Mar 28 23:46:12 2016 -0500
Commit:     Stefano Stabellini <sstabellini@xxxxxxxxxx>
CommitDate: Tue May 17 11:28:17 2016 +0100

    arm: Fix asynchronous aborts (SError exceptions) due to bogus PTEs
    
    ARMv8 architecture allows performing prefetch data/instructions
    from memory locations marked as normal memory. Prefetch does not
    mean that the data/instruction has to be used/executed in code
    flow. All PTEs that appear to be valid to MMU must contain valid
    physical address with proper attributes otherwise MMU table walk
    might cause imprecise asynchronous aborts.
    
    The way current XEN code is preparing page tables for frametable
    and xenheap memory can create bogus PTEs. This patch fixes the
    issue by clearing page table memory before populating EL2 L0/L1
    PTEs. Without this patch XEN crashes on Qualcomm Technologies
    server chips due to asynchronous aborts.
    
    The speculative/prefetch feature explanation is scattered everywhere
    in ARM specification but below two sections have useful information.
    
    E2.8 Memory types and attributes (ver DDI0487A_h)
    G4.12.6 External abort on a translation table walk (ver DDI0487A_h)
    
    Signed-off-by: Vikram Sethi <vikrams@xxxxxxxxxxxxxx>
    Signed-off-by: Shanker Donthineni <shankerd@xxxxxxxxxxxxxx>
    Acked-by: Julien Grall <julien.grall@xxxxxxx>
---
 xen/arch/arm/mm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 7d95961..12190c2 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -724,6 +724,8 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
         else
         {
             unsigned long first_mfn = alloc_boot_pages(1, 1);
+
+            clear_page(mfn_to_virt(first_mfn));
             pte = mfn_to_xen_entry(first_mfn, WRITEALLOC);
             pte.pt.table = 1;
             write_pte(p, pte);
@@ -767,6 +769,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t 
pe)
     second = mfn_to_virt(second_base);
     for ( i = 0; i < nr_second; i++ )
     {
+        clear_page(mfn_to_virt(second_base + i));
         pte = mfn_to_xen_entry(second_base + i, WRITEALLOC);
         pte.pt.table = 1;
         write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], 
pte);
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.5

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog