|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen master] blktap2: initialise buf to NULL in img2qcow.c:main
commit 7e2a1f9402b088c5bf62ceb157e7ea6dfe8196f0
Author: Wei Liu <wei.liu2@xxxxxxxxxx>
AuthorDate: Fri Apr 29 16:11:16 2016 +0100
Commit: Wei Liu <wei.liu2@xxxxxxxxxx>
CommitDate: Fri May 6 15:50:28 2016 +0100
blktap2: initialise buf to NULL in img2qcow.c:main
Gcc complains:
qcow2raw.c: In function â??mainâ??:
qcow2raw.c:387:17: error: â??bufâ?? may be used uninitialized in this
function [-Werror=maybe-uninitialized]
treq.buf = buf;
^
But at the point of that assignment, buf is a valid buffer allocated by
posix_memalign and filled in by read.
Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>
Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
tools/blktap2/drivers/img2qcow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/blktap2/drivers/img2qcow.c b/tools/blktap2/drivers/img2qcow.c
index 57b931e..7376382 100644
--- a/tools/blktap2/drivers/img2qcow.c
+++ b/tools/blktap2/drivers/img2qcow.c
@@ -166,7 +166,7 @@ int main(int argc, const char *argv[])
int ret = -1, fd, len, err;
struct timeval timeout;
uint64_t i;
- char *buf;
+ char *buf = NULL;
td_request_t treq;
td_disk_info_t info;
td_vbd_request_t* vreq;
--
generated by git-patchbot for /home/xen/git/xen.git#master
_______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |