[Xen-changelog] [qemu-xen stable-4.4] exec: fix a glitch in checking dma r/w access

[patchbot@xxxxxxx]

commit 2600664a4e8d333290f01f0a957ea996e300bc6f
Author:     Prasad J Pandit <pjp@xxxxxxxxxxxxxxxxx>
AuthorDate: Mon Jan 25 19:59:50 2016 +0530
Commit:     Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
CommitDate: Fri Feb 5 14:53:53 2016 +0000

    exec: fix a glitch in checking dma r/w access
    
    While checking r/w access in 'memory_access_is_direct' routine
    a glitch in the expression leads to segmentation fault while
    performing dma read operation.
    
    Reported-by: Donghai Zdh <donghai.zdh@xxxxxxxxxxxxxxx>
    Signed-off-by: Prasad J Pandit <pjp@xxxxxxxxxxxxxxxxx>
---
 exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/exec.c b/exec.c
index f3797b7..e64f69b 100644
--- a/exec.c
+++ b/exec.c
@@ -1903,7 +1903,7 @@ static void invalidate_and_set_dirty(hwaddr addr,
 static inline bool memory_access_is_direct(MemoryRegion *mr, bool is_write)
 {
     if (memory_region_is_ram(mr)) {
-        return !(is_write && mr->readonly);
+        return (is_write && !mr->readonly);
     }
     if (memory_region_is_romd(mr)) {
         return !is_write;
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#stable-4.4

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog