[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen master] xen/arm: vgic: Clarify some comments after 5d495f4
commit a6037e6593fe7b44a55304b8c6053088c0cc0441 Author: Julien Grall <julien.grall@xxxxxxxxxx> AuthorDate: Thu Dec 17 17:29:10 2015 +0000 Commit: Ian Campbell <ian.campbell@xxxxxxxxxx> CommitDate: Tue Jan 5 11:48:52 2016 +0000 xen/arm: vgic: Clarify some comments after 5d495f4 Ian pointed out that the definition of "offset" and "appropriate boundary" in the comments added by "xen/arm: vgic: Optimize the way to store the target vCPU in the rank" were not cleared. Clarify them by explicitly mentionning the offset is in byte and the appropriate boundary is ITARGET<n>/IROUTER<n> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> --- xen/arch/arm/vgic-v2.c | 4 ++-- xen/arch/arm/vgic-v3.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index 2c73133..944b004 100644 --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -65,7 +65,7 @@ void vgic_v2_setup_hw(paddr_t dbase, paddr_t cbase, paddr_t csize, * Fetch an ITARGETSR register based on the offset from ITARGETSR0. Only * one vCPU will be listed for a given vIRQ. * - * Note the offset will be aligned to the appropriate boundary. + * Note the byte offset will be aligned to an ITARGETSR<n> boundary. */ static uint32_t vgic_fetch_itargetsr(struct vgic_irq_rank *rank, unsigned int offset) @@ -88,7 +88,7 @@ static uint32_t vgic_fetch_itargetsr(struct vgic_irq_rank *rank, * Store an ITARGETSR register in a convenient way and migrate the vIRQ * if necessary. This function only deals with ITARGETSR8 and onwards. * - * Note the offset will be aligned to the appropriate boundary. + * Note the byte offset will be aligned to an ITARGETSR<n> boundary. */ static void vgic_store_itargetsr(struct domain *d, struct vgic_irq_rank *rank, unsigned int offset, uint32_t itargetsr) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 985e866..5893b71 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -94,7 +94,7 @@ static struct vcpu *vgic_v3_irouter_to_vcpu(struct domain *d, uint64_t irouter) * Fetch an IROUTER register based on the offset from IROUTER0. Only one * vCPU will be listed for a given vIRQ. * - * Note the offset will be aligned to the appropriate boundary. + * Note the byte offset will be aligned to an IROUTER<n> boundary. */ static uint64_t vgic_fetch_irouter(struct vgic_irq_rank *rank, unsigned int offset) -- generated by git-patchbot for /home/xen/git/xen.git#master _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |