[Xen-changelog] [xen stable-4.5] sched: fix locking for insert_vcpu() in credit1 and RTDS

[patchbot@xxxxxxx]

commit 413d59f3e1873fcbc3e67aca8c3a815b0f49cf08
Author:     Dario Faggioli <dario.faggioli@xxxxxxxxxx>
AuthorDate: Tue Dec 15 15:36:26 2015 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Dec 15 15:36:26 2015 +0100

    sched: fix locking for insert_vcpu() in credit1 and RTDS
    
    The insert_vcpu() hook is handled with inconsistent locking.
    In fact, schedule_cpu_switch() calls the hook with runqueue
    lock held, while sched_move_domain() relies on the hook
    implementations to take the lock themselves (and, since that
    is not done in Credit1 and RTDS, such operation is not safe
    in those cases).
    
    This is fixed as follows:
     - take the lock in the hook implementations, in specific
       schedulers' code;
     - avoid calling insert_vcpu(), for the idle vCPU, in
       schedule_cpu_switch(). In fact, idle vCPUs are set to run
       immediately, and the various schedulers won't insert them
       in their runqueues anyway, even when explicitly asked to.
    
    While there, still in schedule_cpu_switch(), locking with
    _irq() is enough (there's no need to do *_irqsave()).
    
    Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
    Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
    Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
    master commit: ae2f41e3d7e7798537b7ea6dbb9a0c6aeb1179e3
    master date: 2015-11-24 14:48:34 +0100
---
 xen/common/sched_credit.c |    6 ++++++
 xen/common/sched_rt.c     |    3 +++
 xen/common/schedule.c     |    6 ++----
 3 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
index 7af910d..2a3a67d 100644
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -889,9 +889,15 @@ static void
 csched_vcpu_insert(const struct scheduler *ops, struct vcpu *vc)
 {
     struct csched_vcpu *svc = vc->sched_priv;
+    spinlock_t *lock;
+    unsigned long flags;
+
+    lock = vcpu_schedule_lock_irqsave(vc, &flags);
 
     if ( !__vcpu_on_runq(svc) && vcpu_runnable(vc) && !vc->is_running )
         __runq_insert(vc->processor, svc);
+
+    vcpu_schedule_unlock_irqrestore(lock, flags, vc);
 }
 
 static void
diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
index e70d6c7..0621780 100644
--- a/xen/common/sched_rt.c
+++ b/xen/common/sched_rt.c
@@ -548,16 +548,19 @@ rt_vcpu_insert(const struct scheduler *ops, struct vcpu 
*vc)
 {
     struct rt_vcpu *svc = rt_vcpu(vc);
     s_time_t now = NOW();
+    spinlock_t *lock;
 
     /* not addlocate idle vcpu to dom vcpu list */
     if ( is_idle_vcpu(vc) )
         return;
 
+    lock = vcpu_schedule_lock_irq(vc);
     if ( now >= svc->cur_deadline )
         rt_update_deadline(now, svc);
 
     if ( !__vcpu_on_q(svc) && vcpu_runnable(vc) && !vc->is_running )
         __runq_insert(ops, svc);
+    vcpu_schedule_unlock_irq(lock, vc);
 
     /* add rt_vcpu svc to scheduler-specific vcpu list of the dom */
     list_add_tail(&svc->sdom_elem, &svc->sdom->vcpu);
diff --git a/xen/common/schedule.c b/xen/common/schedule.c
index 86dc73b..64a619f 100644
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -1435,7 +1435,6 @@ void __init scheduler_init(void)
 
 int schedule_cpu_switch(unsigned int cpu, struct cpupool *c)
 {
-    unsigned long flags;
     struct vcpu *idle;
     spinlock_t *lock;
     void *ppriv, *ppriv_old, *vpriv, *vpriv_old;
@@ -1456,7 +1455,7 @@ int schedule_cpu_switch(unsigned int cpu, struct cpupool 
*c)
         return -ENOMEM;
     }
 
-    lock = pcpu_schedule_lock_irqsave(cpu, &flags);
+    lock = pcpu_schedule_lock_irq(cpu);
 
     SCHED_OP(old_ops, tick_suspend, cpu);
     vpriv_old = idle->sched_priv;
@@ -1465,9 +1464,8 @@ int schedule_cpu_switch(unsigned int cpu, struct cpupool 
*c)
     ppriv_old = per_cpu(schedule_data, cpu).sched_priv;
     per_cpu(schedule_data, cpu).sched_priv = ppriv;
     SCHED_OP(new_ops, tick_resume, cpu);
-    SCHED_OP(new_ops, insert_vcpu, idle);
 
-    pcpu_schedule_unlock_irqrestore(lock, flags, cpu);
+    pcpu_schedule_unlock_irq(lock, cpu);
 
     SCHED_OP(old_ops, free_vdata, vpriv_old);
     SCHED_OP(old_ops, free_pdata, ppriv_old, cpu);
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.5

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog